Quality: Dangling reference expression in MediaRecorder shim#404
Merged
davidliu merged 1 commit intoJun 11, 2026
Merged
Conversation
The final statement 'MediaRecorder' in shimMediaRecorder does nothing and serves no purpose. It appears to be a leftover or mistaken attempt to ensure the module is loaded. Affected files: MediaRecorderShim.ts Signed-off-by: Quang Do <github@qdzsh.dev>
qdzsh
requested review from
davidliu,
hiroshihorie and
xianshijing-lk
as code owners
|
davidliu
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Quality: Dangling reference expression in MediaRecorder shim
Problem
Severity:
Low| File:src/polyfills/MediaRecorderShim.ts:L14The final statement 'MediaRecorder' in shimMediaRecorder does nothing and serves no purpose. It appears to be a leftover or mistaken attempt to ensure the module is loaded.
Solution
Remove the dangling 'MediaRecorder' expression. The import already ensures the module is loaded.
Changes
src/polyfills/MediaRecorderShim.ts(modified)Testing